Skip to content

feat: update default image to ghcr.io one #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2021
Merged

feat: update default image to ghcr.io one #219

merged 1 commit into from
Sep 1, 2021

Conversation

chenrui333
Copy link
Contributor

Description

per Atlantis 0.17.1 release, the default image registry is ghcr.io. Thus updating the code to reflect that.

@antonbabenko antonbabenko changed the title docker: update default image to ghcr.io one feat: update default image to ghcr.io one Sep 1, 2021
@antonbabenko antonbabenko merged commit 3e93a13 into terraform-aws-modules:master Sep 1, 2021
@antonbabenko
Copy link
Member

Thanks @chenrui333 !

v3.1.0 has been just released.

@chenrui333
Copy link
Contributor Author

Thanks @antonbabenko!

@bryantbiggs
Copy link
Member

FYI - I don't think this change does what you think it does. if we wanted to change the image repo, we should have changed the image version to be dev per the directions of upstream Atlantis repo

default = "latest"

@bryantbiggs
Copy link
Member

also, they are still publishing to Dockerhub as well so the "old" route still works

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants