Skip to content

feat: mdawn ecs policy gov compatibility #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mdawn
Copy link

@mdawn mdawn commented Apr 4, 2021

Description

RIght now, the default partition is hard-coded to aws, this leverages the data source aws_partition https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/partition allowing this module to support GovCloud out of the box.

Thanks to @esacteksab for the original inspo to make it compatible.

Motivation and Context

The module out of the box does not support GovCloud. This allows it to.

Breaking Changes

None that I'm aware of.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    Made this change on a local branch and ran it against our GovCloud instance. I see no reason why this would impact anything else.

@mdawn mdawn changed the title mdawn ecs policy gov compatibility feat: mdawn ecs policy gov compatibility Apr 4, 2021
@antonbabenko
Copy link
Member

Hi,

I believe you can just override policies_arn argument with the list of ARNs you have in GovCloud or any other part of AWS (eg, China).

policies_arn = ["arn:aws-us-gov:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"]

There is no need for this pull request.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants