feat: mdawn ecs policy gov compatibility #192
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RIght now, the default partition is hard-coded to
aws
, this leverages the data sourceaws_partition
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/partition allowing this module to support GovCloud out of the box.Thanks to @esacteksab for the original inspo to make it compatible.
Motivation and Context
The module out of the box does not support GovCloud. This allows it to.
Breaking Changes
None that I'm aware of.
How Has This Been Tested?
examples/*
projectsMade this change on a local branch and ran it against our GovCloud instance. I see no reason why this would impact anything else.