feat: allow adding more trusted principals to task role (users and ro…

[kainlite]

Description

This is adding another variable to be able to give some users or other roles the ability to assume the atlantis role, this can be refactored probably but I didn't want to add any breaking change for this simple requirement.

Motivation and Context

While debugging it comes handy to be able to invoke terraform as atlantis does to speed things up, also this is particularly useful when importing resources.

Breaking Changes

Optional variable, it should be a no op if empty.

How Has This Been Tested?

Tested referencing my own branch.

[parmouraly]

Hey @kainlite

Additional trusted principals are already supported from release 2.27.0

https://github.com/terraform-aws-modules/terraform-aws-atlantis/blob/master/variables.tf#L242-L246

[kainlite]

Hey @kainlite

Additional trusted principals are already supported from release 2.27.0

https://github.com/terraform-aws-modules/terraform-aws-atlantis/blob/master/variables.tf#L242-L246

Yes this is very similar, but the trusted_principals is only for AWS Services, my PR gives you the possibility to allow users or other roles to assume the atlantis role, this is particularly useful when importing, so your state gets the right permissions, owner, etc and you don't need to do any additional patching afterwards.

[parmouraly]

Yes this is very similar, but the trusted_principals is only for AWS Services, my PR gives you the possibility to allow users or other roles to assume the atlantis role, this is particularly useful when importing, so your state gets the right permissions, owner, etc and you don't need to do any additional patching afterwards.

Got you, makes sense 👍
I don't perform imports via Atlantis but I guess if you are then I can see the value.

[kainlite]

Updated from master

[OneBadSanta]

I need this functionality as well. This has been sitting for a while. Is there any technical reason why this has not been merged?

[antonbabenko]

Please use v2.37.0 which has been just released (#193).

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.