feat: support custom platform version #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jychen7
changed the title
jychen7
force-pushed
the
ecs-support-platform-version
branch
2 times, most recently
from
91df9ba to
ae820e2
Compare
jychen7
changed the title
jychen7
force-pushed
the
ecs-support-platform-version
branch
from
ae820e2 to
6aeebf6
Compare
jychen7
force-pushed
the
ecs-support-platform-version
branch
from
6aeebf6 to
1756d3f
Compare
bryantbiggs
approved these changes
Dec 20, 2020
|
@jychen7 it would be good if you could update the |
This was referenced Dec 23, 2020
@bryantbiggs sure, done in 5826a01 |
|
thank you @jychen7 - @antonbabenko good to go 👍🏼 |
|
Great! v2.29.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to set custom ECS Fargate platform version
Motivation and Context
currently, by default, ECS Fargate is using platform version 1.3.0
However, 1.4.0 introduce more features I would like Atlantis to use, including
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/platform_versions.html
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/fargate-task-storage.html
Breaking Changes
Nope, new variables are backward compatible and match existing defaults
How Has This Been Tested?
planed and applied