Skip to content

feat: update container definition including additional parameters to configure #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

feat: update container definition including additional parameters to configure #144

wants to merge 7 commits into from

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Jul 26, 2020

Description

  • Update module dependencies to latest; this is a no-op change when tested
  • Update container definition to include additional parameters that are available by the module for those that are relevant to Fargate (allows for more configuration and flexibility)
  • Add complete example with GitHub webhooks for testing as well as demonstrating module usage
  • Update pre-commit to latest and remove validate (requires terraform init to be run prior on all workspaces/root directories)
  • Update modules to support AWS provider 3.x and Terraform 0.13.x

Motivation and Context

Breaking Changes

  • None at this time

How Has This Been Tested?

  1. I have an existing Atlantis module running in production on v2.20.0. Updating the source to point to this change request showed no updates to be made
  2. There is now an example for testing/validation under examples/github-complete which includes both the Atlantis resources (including VPC and access logging bucket) as well as GitHub webhooks which also validated the changes when run anew

Copy link
Contributor

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes.

im able to provision thie module properly by atlantis doesnt start. i dont have time to go to much into looking into it at the moment.

BTW, on an unrelated note to PR it would be nice to have a guide on how to create the access token for github and what permissions are needed (hooks). i didnt see anything like this in the module.

@bryantbiggs
Copy link
Member Author

@antonbabenko if you get a minute - the complete example works and I've tested this on 2 other existing deployments

@antonbabenko
Copy link
Member

antonbabenko commented Aug 15, 2020

@bryantbiggs Thanks! I will proceed with this and several other PRs in the VPC and S3 modules where you have tagged me earlier on Monday.

@antonbabenko
Copy link
Member

Thanks, @bryantbiggs !

v2.21.0 has been released.

PS: I used to make a new PR #148 because I can't push to your fork.

@antonbabenko
Copy link
Member

Could you please close/update related issues/PRs you mentioned in this PR, too?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to specify ECS container ulimits
3 participants