-
-
Notifications
You must be signed in to change notification settings - Fork 355
feat: update container definition including additional parameters to configure #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update container definition including additional parameters to configure #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor changes.
im able to provision thie module properly by atlantis doesnt start. i dont have time to go to much into looking into it at the moment.
BTW, on an unrelated note to PR it would be nice to have a guide on how to create the access token for github and what permissions are needed (hooks). i didnt see anything like this in the module.
- fix: add github webhook url subnets to security group when github webhook urls are allowed. fixes case when not using 0.0.0.0/0
@antonbabenko if you get a minute - the complete example works and I've tested this on 2 other existing deployments |
@bryantbiggs Thanks! I will proceed with this and several other PRs in the VPC and S3 modules where you have tagged me earlier on Monday. |
Thanks, @bryantbiggs ! v2.21.0 has been released. PS: I used to make a new PR #148 because I can't push to your fork. |
Could you please close/update related issues/PRs you mentioned in this PR, too? |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
terraform init
to be run prior on all workspaces/root directories)Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/github-complete
which includes both the Atlantis resources (including VPC and access logging bucket) as well as GitHub webhooks which also validated the changes when run anew