Skip to content

fix: cognito variables expect "user_pool_client_id" and "user_pool_domain" #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2020
Merged

fix: cognito variables expect "user_pool_client_id" and "user_pool_domain" #134

merged 2 commits into from
Jun 17, 2020

Conversation

brdly-smith
Copy link
Contributor

Description

Error in readme for cognito variables.

main.tf line 208, in resource "aws_lb_listener" "frontend_https":
 208:           user_pool_domain                    = authenticate_cognito.value["user_pool_domain"]
    |----------------
    | authenticate_cognito.value is object with 3 attributes

The given key does not identify an element in this collection value.

@brdly-smith brdly-smith changed the title cognito variables expect "user_pool_client_id" and "user_pool_domain" fix: cognito variables expect "user_pool_client_id" and "user_pool_domain" Jun 17, 2020
antonbabenko
antonbabenko reviewed Jun 17, 2020
View reviewed changes
README.md Outdated
@@ -133,8 +133,8 @@ To enable Cognito authentication on the Atlantis ALB, specify the following argu
```hcl
alb_authenticate_cognito = {
user_pool_arn = "arn:aws:cognito-idp:us-west-2:1234567890:userpool/us-west-2_aBcDeFG"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix alignment here, too.

@antonbabenko antonbabenko merged commit 8531cd0 into terraform-aws-modules:master Jun 17, 2020
@antonbabenko
Copy link
Member

Thanks, @brdly-smith !

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brdly-smith @antonbabenko