Skip to content

feat: Updated versions of VPC, SG, ACM modules #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2020
Merged

Conversation

antonbabenko
Copy link
Member

Minor recreation of resources were required.

  # module.atlantis_sg.aws_security_group_rule.computed_ingress_with_source_security_group_id[0] will be destroyed

  # module.atlantis_sg.aws_security_group_rule.ingress_with_source_security_group_id[0] will be created
  + resource "aws_security_group_rule" "ingress_with_source_security_group_id" {

  # module.acm.aws_acm_certificate_validation.this[0] must be replaced
  -/+ resource "aws_acm_certificate_validation" "this" {

  # module.acm.aws_route53_record.validation[1] will be created

@@ -274,7 +272,7 @@ module "atlantis_sg" {
###################
module "acm" {
source = "terraform-aws-modules/acm/aws"
version = "v2.4.0"
version = "v2.5.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACM module v2.5.0 is not ideal but it works for the majority of cases.

@antonbabenko antonbabenko merged commit 9d6ce45 into master May 12, 2020
@antonbabenko antonbabenko deleted the update-versions branch May 12, 2020 09:09
@antonbabenko
Copy link
Member Author

v2.10.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant