-
-
Notifications
You must be signed in to change notification settings - Fork 355
Only create VPC if no VPC ID is passed #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@bsuv Thanks for opening this issue! You are literally reading my mind. :) I am working on it right now. Expect a PR in a couple of hours with some more enhancements like this. |
The weather was so good today, so it took me a little bit longer to complete this. v1.1.0 has been released and there is a possibility to reuse existing VPC and subnets. |
…upport Add bootstrap option for github-complete example and move Github App …
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
terraform-aws-atlantis/main.tf
Line 18 in 508eb0c
Great work Anton!
Recently I also developed an Atlantis module to which I pass a
vpc_id
as a variable instead of acidr_block
to create a new one - under the assumption that it's more common for someone to deploy Atlantis in an existing VPC.My proposal:
cidr_block
andvpc_id
), both with dummy defaults.count
to determine whether a new VPC is needed, in which case thecidr_block
would be used.The text was updated successfully, but these errors were encountered: