Skip to content

Only create VPC if no VPC ID is passed #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bsuv opened this issue May 26, 2018 · 3 comments · Fixed by #12
Closed

Only create VPC if no VPC ID is passed #6

bsuv opened this issue May 26, 2018 · 3 comments · Fixed by #12

Comments

@bsuv
Copy link

bsuv commented May 26, 2018

module "vpc" {

Great work Anton!

Recently I also developed an Atlantis module to which I pass a vpc_id as a variable instead of a cidr_block to create a new one - under the assumption that it's more common for someone to deploy Atlantis in an existing VPC.

My proposal:

  • have 2 input variables (cidr_block and vpc_id), both with dummy defaults.
  • use count to determine whether a new VPC is needed, in which case the cidr_block would be used.
@antonbabenko
Copy link
Member

@bsuv Thanks for opening this issue!

You are literally reading my mind. :) I am working on it right now. Expect a PR in a couple of hours with some more enhancements like this.

@antonbabenko antonbabenko changed the title Only create VPC iff no VPC ID is passed Only create VPC if no VPC ID is passed May 26, 2018
@antonbabenko
Copy link
Member

The weather was so good today, so it took me a little bit longer to complete this.

v1.1.0 has been released and there is a possibility to reuse existing VPC and subnets.

dynamike pushed a commit to dynamike/terraform-aws-atlantis that referenced this issue Oct 27, 2022
…upport

Add bootstrap option for github-complete example and move Github App …
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants