Skip to content

feat: Add task_execution_session_duration for task execution role #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

itmustbejj
Copy link
Contributor

Description

Add var.task_execution_session_duration for task execution role.

image
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role

Motivation and Context

The default max_session_duration for iam roles of 1 hour is insufficient for long-running terraform applies. This leads to runs breaking and failing to persist their state in s3, and often requires painful manual cleanup.

Breaking Changes

None

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@itmustbejj
Copy link
Contributor Author

This is a resubmission of #251 which was closed due to inactivity.

@bryantbiggs bryantbiggs changed the title feat: Add var.task_execution_session_duration for task execution role feat: Add task_execution_session_duration for task execution role Jul 14, 2022
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies on the other PR, but thanks for following up!

@bryantbiggs bryantbiggs merged commit 16162ff into terraform-aws-modules:master Jul 14, 2022
antonbabenko pushed a commit that referenced this pull request Jul 14, 2022
## [3.18.0](v3.17.1...v3.18.0) (2022-07-14)

### Features

* Add `task_execution_session_duration` for task execution role ([#300](#300)) ([16162ff](16162ff))
@antonbabenko
Copy link
Member

This PR is included in version 3.18.0 🎉

@itmustbejj itmustbejj deleted the feat/execution-role-session-duration branch July 27, 2022 21:08
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants