feat: Add support for runtime_platform config block #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
May 15, 2022
bryantbiggs
reviewed
May 15, 2022
bryantbiggs
reviewed
May 15, 2022
bryantbiggs
reviewed
May 15, 2022
bryantbiggs
reviewed
May 15, 2022
Co-authored-by: Bryant Biggs <[email protected]>
Co-authored-by: Bryant Biggs <[email protected]>
Co-authored-by: Bryant Biggs <[email protected]>
Co-authored-by: Bryant Biggs <[email protected]>
Co-authored-by: Bryant Biggs <[email protected]>
|
@bryantbiggs I applied all of your suggestions and then tested the code again using |
bryantbiggs
approved these changes
May 15, 2022
antonbabenko
pushed a commit
that referenced
this pull request
May 15, 2022
## [3.16.0](v3.15.1...v3.16.0) (2022-05-15) ### Features * Add support for runtime_platform config block ([#279](#279)) ([4b93dee](4b93dee))
|
This PR is included in version 3.16.0 🎉 |
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 8, 2022
…dules#279) Co-authored-by: Bryant Biggs <[email protected]>
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 8, 2022
## [3.16.0](terraform-aws-modules/terraform-aws-atlantis@v3.15.1...v3.16.0) (2022-05-15) ### Features * Add support for runtime_platform config block ([terraform-aws-modules#279](terraform-aws-modules#279)) ([4b93dee](terraform-aws-modules@4b93dee))
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 8, 2022
…dules#279) Co-authored-by: Bryant Biggs <[email protected]>
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 8, 2022
## [3.16.0](terraform-aws-modules/terraform-aws-atlantis@v3.15.1...v3.16.0) (2022-05-15) ### Features * Add support for runtime_platform config block ([terraform-aws-modules#279](terraform-aws-modules#279)) ([4b93dee](terraform-aws-modules@4b93dee))
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 9, 2022
…dules#279) Co-authored-by: Bryant Biggs <[email protected]>
titanlien
pushed a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Jun 9, 2022
## [3.16.0](terraform-aws-modules/terraform-aws-atlantis@v3.15.1...v3.16.0) (2022-05-15) ### Features * Add support for runtime_platform config block ([terraform-aws-modules#279](terraform-aws-modules#279)) ([4b93dee](terraform-aws-modules@4b93dee))
3 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes add support for
runtime_platformconfiguration block toaws_ecs_task_definition. This option allows running Atlantis on a custom Operating system and custom Architecture on Fargate.Motivation and Context
Closes #273
Breaking Changes
The minimum AWS provider version was updated 3.45 -> 3.69 (AWS provider PR)
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request