Skip to content

BREAKING CHANGE: update internal modules to latest, replace github_organization with github_owner, bump Terraform version to >=0.13.1 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Aug 30, 2021

Description

  • add data source for using correct partition based on where Atlantis is provisioned for the default ECS task execution policy ARN
  • update sub-modules to use latest versions; GitHub version need to be updated for deprecating changes
  • bump min Terraform version to 0.13.1+ due to module and provider support
  • replace github_organization with github_owner due to deprecation in the GitHub provider
  • switch policy ARN attachment from count to for_each
  • correct github-complete example project so it works correctly again (trusted principals and trusted entities)

Motivation and Context

Closes #190
Closes #192
Closes #201

Breaking Changes

  • Yes; support for Terraform v0.12.x is dropped, and GitHub provider min version supported raised to v4.8.x for deprecation of github_organization

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    • complete example updated and validated with test projects
    • also fixed/updated GitHub webhook example project

@antonbabenko
Copy link
Member

I know the PR is not ready but trusted_principals and trusted_entities are rather handy to have. Good night :)

@bryantbiggs bryantbiggs changed the title chore: update internal modules to latest and update GitHub provider to remove warning BREAKING CHANGE: update internal modules to latest and update GitHub provider to remove warning Aug 30, 2021
@bryantbiggs bryantbiggs changed the title BREAKING CHANGE: update internal modules to latest and update GitHub provider to remove warning BREAKING CHANGE: update internal modules to latest, replace github_organization with github_owner, bump Terraform version to >=0.13.1 Aug 30, 2021
@antonbabenko antonbabenko merged commit c4de355 into terraform-aws-modules:master Aug 31, 2021
@antonbabenko
Copy link
Member

Thanks, @bryantbiggs !

https://github.com/terraform-aws-modules/terraform-aws-atlantis/releases/tag/v3.0.0

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants