feat: allow adding more trusted principals to task role #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
reviewed
Apr 7, 2021
|
Thank you, @OneBadSanta ! v2.37.0 has been just released. |
|
@antonbabenko Changes look great. Thanks so much :) |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of a PR from @kainlite (link below). The original PR did not allow for an empty value for trusted_entities. I created this separate PR because I did not honestly know how to contribute to another users PR.
#173 (comment)
Description
This is adding another variable to be able to give some users or other roles the ability to assume the Atlantis role.
Motivation and Context
While debugging it comes handy to be able to invoke terraform as Atlantis does to speed things up, also this is particularly useful when importing resources.
Breaking Changes
None
How Has This Been Tested?
Tested referencing my own branch.