Skip to content

Option to add sidecars #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nitrocode opened this issue Jun 16, 2020 · 4 comments
Closed

Option to add sidecars #133

nitrocode opened this issue Jun 16, 2020 · 4 comments

Comments

@nitrocode
Copy link
Member

Instead of overwriting the entire container definition, it would be nice to be able to append sidecars. For instance, I'd like to use the ddagent sidecar for datadog metrics and fluentbit sidecar to push logs to datadog.

marcoceppi added a commit to stacklet/terraform-aws-atlantis that referenced this issue Oct 29, 2020
marcoceppi added a commit to stacklet/terraform-aws-atlantis that referenced this issue Oct 29, 2020
marcoceppi added a commit to stacklet/terraform-aws-atlantis that referenced this issue Nov 11, 2020
marcoceppi added a commit to stacklet/terraform-aws-atlantis that referenced this issue Nov 11, 2020
@marcoceppi
Copy link
Contributor

@antonbabenko this can be closed now, thank you again!

@antonbabenko
Copy link
Member

Great @marcoceppi !

@nitrocode Please use v2.26.0 for this feature.

@jaredtkatz
Copy link

jaredtkatz commented Nov 30, 2020

Raising a question here since this is the most relevant issue I can find... Does anyone (@antonbabenko?) have thoughts on somehow exposing the volume block for the Atlantis ecs_task_definition as a top-level variable for this module so users can optionally specify a Docker or EFS volume? I've personally been bumping up against the limits of the 20GB of storage provided by default for Fargate tasks. The ability to specify a Docker or EFS volume for the Atlantis task's container(s) would be nice. However, this might already be possible and I'm missing something, so I thought I'd sanity check here before creating an issue. Thanks!

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants