addpkg(main/apkeditor): 1.4.2 #24426
Conversation
|
There was a problem hiding this comment.
(This is a pre-written reply)
I can't seem to find a package request for this project.
So I'll just go through an abbreviated version of the package request checklist below really quick.
Note
For future reference, please open a package request before spending the time to write a package build.
Package requests give us a heads up to evaluate if a package is suitable for packaging in the main Termux repositories.
https://github.com/termux/termux-packages/issues/new?template=02-package-request.yml
If you intend to package
Not all projects will meet out packaging guidelines.
In case this project does not, it may still be suitable for inclusion in the TUR
Packaging policy acknowledgement
-
The project is actively developed.
-
The project has existing packages and is "well known".
-
Licensed under an open source license.
-
Not available through a language package manager: pip, npm, cpan, cargo, etc.
-
Not taking up too much disk space (< 100MiB per architecture, exceptions can be made)
-
Not duplicating the functionality of existing packages.
-
Not serving hacking, malware, phishing, spamming, spying, ddos functionality.
-
I certify that I have read Termux Packaging Policy and understand that my request will be denied if it is found lacking.
This is a bit of an odd case.
packages/apkeditor/build.sh
Outdated
| TERMUX_PKG_SKIP_SRC_EXTRACT=true | ||
| TERMUX_PKG_ON_DEVICE_BUILD_NOT_SUPPORTED=true | ||
|
|
||
| RAW_JAR=$TERMUX_PKG_CACHEDIR/APKEditor-${TERMUX_PKG_VERSION}.jar |
There was a problem hiding this comment.
We don't usually add "global" non-standard control variable outside of build step functions.
packages/apkeditor/build.sh
Outdated
| mkdir -p $TERMUX_PKG_SRCDIR | ||
| termux_download $TERMUX_PKG_SRCURL \ | ||
| $RAW_JAR \ | ||
| $TERMUX_PKG_SHA256 |
There was a problem hiding this comment.
There should be no need to override the download step.
This is a regular github release artifact and the standard version of termux_step_get_source can handle that just fine.
There was a problem hiding this comment.
With TERMUX_PKG_SKIP_SRC_EXTRACT=true.
If don't add termux_step_get_source() then where is the downloaded raw jar?
There was a problem hiding this comment.
Package sources are placed into $TERMUX_PKG_SRCDIR.
See: https://github.com/termux/termux-packages/wiki/Creating-new-package#reserved-package-build-variables
packages/apkeditor/build.sh
Outdated
|
|
||
| termux_step_make_install() { | ||
| install -Dm600 $RAW_JAR \ | ||
| $TERMUX_PREFIX/share/java/apkeditor.jar |
There was a problem hiding this comment.
This should probably go into $PREFIX/libexec/apkeditor/apkeditor.jar,
but I'm not entirely sure if that's the convention we use for java packages.
| TERMUX_PKG_LICENSE="Apache-2.0" | ||
| TERMUX_PKG_MAINTAINER="@Veha0001" | ||
| TERMUX_PKG_VERSION=1.4.2 | ||
| TERMUX_PKG_SRCURL=https://github.com/REAndroid/APKEditor/releases/download/V${TERMUX_PKG_VERSION}/APKEditor-${TERMUX_PKG_VERSION}.jar |
There was a problem hiding this comment.
The appears to be a precompiled release JAR.
That is fine for Java I suppose, but it's unusually since we usually compile packages from source.
packages/apkeditor/build.sh
Outdated
| TERMUX_PKG_BUILD_IN_SRC=true | ||
| TERMUX_PKG_PLATFORM_INDEPENDENT=true | ||
| TERMUX_PKG_SKIP_SRC_EXTRACT=true | ||
| TERMUX_PKG_ON_DEVICE_BUILD_NOT_SUPPORTED=true |
There was a problem hiding this comment.
This build script just downloads a JAR and puts it in the directory it needs to go.
Why would it be unsafe for on device builds?
|
Most of this Why not..: REAndroid/APKEditor#180 |
|
I think I updated all the outdated. |
|
This can be run just by downloading the release pkg upgrade
pkg install openjdk-17
java -jar apkeditor.jarthat seems to me like there is no special setup or compilation needed, so it seems unnecessary for it to come from |
|
It is how the project is documented for use, so In my opinion it is easier to copy and paste commands from the project README, if the users already know where they downloaded the |
|
Close (termux-user-repository/tur#1687). Thanks 🙏 |
No description provided.