Skip to content

Edited issue template for concision #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 11, 2018
Merged

Conversation

Git-Good
Copy link
Contributor

@Git-Good Git-Good commented Apr 4, 2018

Improved readability and comprehension.


This change is Reviewable

Improved readability and comprehension.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@Git-Good
Copy link
Contributor Author

Git-Good commented Apr 4, 2018

I signed the CLA

@googlebot
Copy link

CLAs look good, thanks!

@nsthorat
Copy link
Contributor

nsthorat commented Apr 4, 2018

:lgtm_strong:

Looks good, couple small things then I will merge it. In generally I like the more concise language.


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


ISSUE_TEMPLATE.md, line 3 at r1 (raw file):

To get help from the community, check out our [Google group](https://groups.google.com/a/tensorflow.org/forum/#!forum/tfjs).

Else, submit an issue based on the following template. 

s/Else/Otherwise


ISSUE_TEMPLATE.md, line 5 at r1 (raw file):

Else, submit an issue based on the following template. 

Issue Template:

I would just remove this line


Comments from Reviewable

@nsthorat
Copy link
Contributor

nsthorat commented Apr 5, 2018

:lgtm_strong:


Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


Comments from Reviewable

@nsthorat
Copy link
Contributor

nsthorat commented Apr 5, 2018

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


ISSUE_TEMPLATE.md, line 5 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

I would just remove this line

Sorry, I actually meant remove this "Issue Template" line :) Then I will merge, apologies for the round trip!


Comments from Reviewable

@caisq
Copy link
Contributor

caisq commented Apr 11, 2018

Ping @nsthorat?

@nsthorat
Copy link
Contributor

Waiting for the removal of "Issue Template:" but maybe I should just merge and I'll do it.

@caisq
Copy link
Contributor

caisq commented Apr 11, 2018

@nsthorat FYI, you can apply edits to a PR on GitHub. Let me know if you need help finding out how to do that.

@nsthorat
Copy link
Contributor

Done.

@nsthorat nsthorat merged commit a5a5b46 into tensorflow:master Apr 11, 2018
easadler pushed a commit to easadler/tfjs that referenced this pull request Apr 12, 2018
* Use underscore naming instead of camel case.

Renamed `momentumOptimizer.ts` -> `momentum_optimizer.ts`

* Merge branch 'master' into underscore-naming
nsthorat pushed a commit that referenced this pull request Aug 19, 2019
* Change API registration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants