-
Notifications
You must be signed in to change notification settings - Fork 2k
Edited issue template for concision #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Improved readability and comprehension.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed the CLA |
CLAs look good, thanks! |
Looks good, couple small things then I will merge it. In generally I like the more concise language. Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. ISSUE_TEMPLATE.md, line 3 at r1 (raw file):
s/Else/Otherwise ISSUE_TEMPLATE.md, line 5 at r1 (raw file):
I would just remove this line Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending. ISSUE_TEMPLATE.md, line 5 at r1 (raw file): Previously, nsthorat (Nikhil Thorat) wrote…
Sorry, I actually meant remove this "Issue Template" line :) Then I will merge, apologies for the round trip! Comments from Reviewable |
Ping @nsthorat? |
Waiting for the removal of "Issue Template:" but maybe I should just merge and I'll do it. |
@nsthorat FYI, you can apply edits to a PR on GitHub. Let me know if you need help finding out how to do that. |
Done. |
* Use underscore naming instead of camel case. Renamed `momentumOptimizer.ts` -> `momentum_optimizer.ts` * Merge branch 'master' into underscore-naming
Improved readability and comprehension.
This change is