Return NonRetryableApplicationError if Namespace is not found on remote cluster during verify #4786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te cluster during verify
meiliang86
approved these changes
Aug 21, 2023
hehaifengcn
added a commit
that referenced
this pull request
Aug 22, 2023
…te cluster during verify (#4786) <!-- Describe what has changed in this PR --> **What changed?** During force replication, namespace should exist on remote (target cluster). If namespace doesn't exist (due to operator error e.g.,), fail VerifyReplicationTasks activity fast. Otherwise, workflow will retry VerifyReplicationTasks activity infinitely. <!-- Tell your future self why have you made these changes --> **Why?** <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
During force replication, namespace should exist on remote (target cluster). If namespace doesn't exist (due to operator error e.g.,), fail VerifyReplicationTasks activity fast. Otherwise, workflow will retry VerifyReplicationTasks activity infinitely.
Why?
How did you test it?
Potential risks
Is hotfix candidate?