Update gcp audit logging #3563
Merged
Update gcp audit logging #3563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised draft, audit logs integration GCP.
Replacing audit-logging-pub-sub-gcp.png
Replacing audit-logging-pub-sub-gcp.png
Turn on visibility
|
Note: sidebars.js use "/path/to/folder/id-from-metadata" and not "/path/to/file" |
alice-yin
reviewed
May 1, 2025
alice-yin
reviewed
May 1, 2025
alice-yin
reviewed
May 1, 2025
Full revision of audit-logging-gcp.mdx, based on new information.
Updated screenshot
Adding audit-logging-gcp to sidebar
Fix formatting, restore image
alice-yin
reviewed
May 3, 2025
alice-yin
reviewed
May 3, 2025
alice-yin
reviewed
May 3, 2025
Comment on lines
39
to
40
| 1. Set up a service account in the same project in Google Cloud that trusts the Temporal internal | ||
| service account to let Temporal write information to your Google Cloud account. |
There was a problem hiding this comment.
- Set up a service account in the same project in Google Cloud and follows guide on temporal cloud UI to configure permissions.
There was a problem hiding this comment.
I made this change. I'm not super comfortable with "follow the instructions in the UI" as the best advice we could give the user. Is this configuration covered anywhere in our docs?
alice-yin
reviewed
May 3, 2025
brianmacdonald-temporal
changed the title
Updating per @alice-yin 's feedback
alice-yin
reviewed
May 5, 2025
alice-yin
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://temporalio.atlassian.net/browse/EDU-4432
What does this PR do?
Update to CGP Pub/Sub audit logging page, with new text and screenshot.
Notes to reviewers