💥[breaking] Remove cloud files #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Apr 23, 2025
There was a problem hiding this comment.
This is great, thanks! @anekkanti - can you confirm this looks good to you? @Quinn-With-Two-Ns - any concerns about newer API versions no longer working with older Go SDKs that include the cloud ops API (until we removed at temporalio/sdk-go#1831)? @yuandrew - can you put a 💥 on the PR title and clarify that it's a breaking change to an experimental thing, that way they know to call it out in release notes.
|
As long as the most recent released Go SDK works I have no concern. @yuandrew can you just confirm that? |
cretz
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
(confirmed off-PR that @anekkanti approves and that this package is not in use in latest released Go SDK)
Quinn-With-Two-Ns
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Removed all cloud files, now that they live at https://github.com/temporalio/cloud-sdk-go
Why?
Cloud files have been moved to their own repo, no need to keep them here anymore.
The Go SDK's has not used cloud protos for a few releases now, so this should be safe.
temporalio/sdk-go#1921
How did you test it?
Potential risks