Skip to content

Add a telepresence wiretap command. #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2025
Merged

Add a telepresence wiretap command. #3825

merged 3 commits into from
Mar 27, 2025

Conversation

thallgren
Copy link
Member

A wiretap is a read-only form of an intercept. The original container will still receive the wiretapped traffic, and a copy of the traffic is sent to the client. Writes on the client connection are discarded.

Similar to an ingest, a wiretap will always enforce read-only status on all volume mounts, and since the wiretap then is completely read-only, there's no limit to how many simultaneous wiretaps that can be served.

@thallgren thallgren marked this pull request as draft March 20, 2025 17:17
@thallgren thallgren requested a review from P0lip March 20, 2025 17:18
@thallgren thallgren force-pushed the thallgren/wiretap branch 2 times, most recently from 8f58f54 to 7fb907b Compare March 21, 2025 07:32
@thallgren thallgren requested review from FuYu3699 and njayp March 22, 2025 07:27
@thallgren thallgren marked this pull request as ready for review March 22, 2025 07:27
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 22, 2025
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 22, 2025
@thallgren thallgren added the feature New feature or enhancement request label Mar 22, 2025
@thallgren thallgren self-assigned this Mar 22, 2025
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 22, 2025
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 22, 2025
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 23, 2025
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 23, 2025
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 23, 2025
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 23, 2025
@thallgren thallgren force-pushed the thallgren/wiretap branch 2 times, most recently from 3f0753f to 690a5b9 Compare March 24, 2025 09:10
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 24, 2025
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 24, 2025
@thallgren thallgren changed the base branch from release/v2 to thallgren/agentpf March 24, 2025 10:51
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 24, 2025
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 24, 2025
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 24, 2025
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 24, 2025
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 24, 2025
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 24, 2025
Base automatically changed from thallgren/agentpf to release/v2 March 26, 2025 15:26
Signed-off-by: Thomas Hallgren <[email protected]>
A wiretap is a read-only form of an intercept. The original container
will still receive the wiretapped traffic, and a copy of the traffic
is sent to the client. Writes on the client connection are discarded.

Similar to an ingest, a wiretap will always enforce read-only status on
all volume mounts, and since the wiretap then is completely read-only,
there's no limit to how many simultaneous wiretaps that can be served.

Signed-off-by: Thomas Hallgren <[email protected]>
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 26, 2025
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Mar 26, 2025
@thallgren thallgren merged commit 4d2bee9 into release/v2 Mar 27, 2025
11 checks passed
@thallgren thallgren deleted the thallgren/wiretap branch March 27, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or enhancement request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant