Rename charts/telepresence to charts/telepresence-oss. #3802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
approved these changes
Feb 20, 2025
| @@ -108,12 +106,6 @@ func (ha *HelmCommand) addValueSettingFlags(flags *pflag.FlagSet) { | |||
| } | |||
| } | |||
|
|
|||
| func (ha *HelmCommand) addCRDsFlags(flags *pflag.FlagSet) { | |||
| if HelmExtendFlagsFunc != nil { | |||
There was a problem hiding this comment.
At this point, we should probably just remove HelmExtendFlagsFunc altogether as it's not consumed anymore.
thallgren
force-pushed
the
thallgren/recursion-check-config
branch
from
e4cf0b1 to
4a5846c
Compare
Base automatically changed from
thallgren/recursion-check-config
to
release/v2
February 21, 2025 16:47
The Helm chart name "telepresence-oss" was inconsistent with its contained folder "telepresence". As a result, attempts to install the chart using an argo ApplicationSet failed. The contained folder was renamed to match the chart name. This commit renames the folder and also removes old code related to "telepresence-crds". Telepresence OSS has no CRDs. Closes #3801 Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/rename-chart-folder
branch
from
37429b4 to
e9bd0e4
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Helm chart name "telepresence-oss" was inconsistent with its contained folder "telepresence". As a result, attempts to install the chart using an argo ApplicationSet failed. The contained folder was renamed to match the chart name.
This commit renames the folder and also removes old code related to "telepresence-crds". Telepresence OSS has no CRDs.
Closes #3801