-
Notifications
You must be signed in to change notification settings - Fork 85
Support for release to ghcr.io #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tekton projects now release to ghcr.io. This PR adapts the existing release pipeline to support releasing to ghcr.io as well. Workload identity can still be use to publish the YAMLs to the gcr.io bucket, but images will be published to the container registry through a PAT stored on the cluster. This updates related resources and docs, and introduces remote resolution for tasks that are already available elsewhere. Signed-off-by: Andrea Frittoli <[email protected]>
baed995
to
5b85e6d
Compare
@tektoncd/results-maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @khrm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The linter job is broken here too... :(
@vdemeester do you want to switch this one to the GitHub action too? |
Yeah I think so. |
Can someone from the results team make the change? |
@khrm 🙏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sure. I am changing the linter. |
Thank you! Let me know if you have any questions- you can check what we did in the plumbing and pipeline repos already for reference, e.g. tektoncd/pipeline#8480 |
/test pull-tekton-results-build-tests |
/test pull-tekton-results-unit-tests |
/cherry-pick release-v0.12.x |
/cherry-pick release-v0.13.x |
@khrm: new pull request created: #930 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@khrm: new pull request created: #931 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
Tekton projects now release to ghcr.io. This PR adapts the existing release pipeline to support releasing to ghcr.io as well.
Workload identity can still be use to publish the YAMLs to the gcr.io bucket, but images will be published to the container registry through a PAT stored on the cluster.
This updates related resources and docs, and introduces remote resolution for tasks that are already available elsewhere.
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes