Skip to content

Support for release to ghcr.io #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

afrittoli
Copy link
Member

Changes

Tekton projects now release to ghcr.io. This PR adapts the existing release pipeline to support releasing to ghcr.io as well.

Workload identity can still be use to publish the YAMLs to the gcr.io bucket, but images will be published to the container registry through a PAT stored on the cluster.

This updates related resources and docs, and introduces remote resolution for tasks that are already available elsewhere.

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Releases will be published to ghcr.io

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2025
@afrittoli
Copy link
Member Author

Tekton projects now release to ghcr.io. This PR adapts
the existing release pipeline to support releasing to
ghcr.io as well.

Workload identity can still be use to publish the YAMLs
to the gcr.io bucket, but images will be published to
the container registry through a PAT stored on the cluster.

This updates related resources and docs, and introduces
remote resolution for tasks that are already available
elsewhere.

Signed-off-by: Andrea Frittoli <[email protected]>
@afrittoli
Copy link
Member Author

@tektoncd/results-maintainers

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @khrm

@tekton-robot tekton-robot requested a review from khrm January 14, 2025 11:41
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@afrittoli
Copy link
Member Author

The linter job is broken here too... :(

level=error msg="[linters_context/goanalysis] SA5012: panic during analysis: interface conversion: interface {} is nil, not *buildir.IR, goroutine 19980 [running]:\nruntime/debug.Stack()\n\t/usr/local/go/src/runtime/debug/stack.go:26 +0x5e\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func1()\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:105 +0x5a\npanic({0x166d980?, 0xc006ea7aa0?})\n\t/usr/local/go/src/runtime/panic.go:785 +0x132\nhonnef.co/go/tools/staticcheck.findSliceLenChecks(0xc002cb3a40)\n\t/home/prow/go/pkg/mod/honnef.co/go/[email protected]/staticcheck/lint.go:4271 +0x668\nhonnef.co/go/tools/staticcheck.CheckEvenSliceLength(0xc002cb3a40)\n\t/home/prow/go/pkg/mod/honnef.co/go/[email protected]/staticcheck/lint.go:4509 +0x18\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyze(0xc004358e40)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:195 +0x967\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func2()\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:113 +0x17\ngithub.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc00210b360, {0x17bf943, 0x6}, 0xc002a0a748)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/timeutils/stopwatch.go:111 +0x44\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe(0xc0036b6540?)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:112 +0x6e\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze.func2(0xc004358e40)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_loadingpackage.go:80 +0xa5\ncreated by github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze in goroutine 351\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_loadingpackage.go:75 +0x1e9\n"

@vdemeester do you want to switch this one to the GitHub action too?

@vdemeester
Copy link
Member

The linter job is broken here too... :(

level=error msg="[linters_context/goanalysis] SA5012: panic during analysis: interface conversion: interface {} is nil, not *buildir.IR, goroutine 19980 [running]:\nruntime/debug.Stack()\n\t/usr/local/go/src/runtime/debug/stack.go:26 +0x5e\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func1()\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:105 +0x5a\npanic({0x166d980?, 0xc006ea7aa0?})\n\t/usr/local/go/src/runtime/panic.go:785 +0x132\nhonnef.co/go/tools/staticcheck.findSliceLenChecks(0xc002cb3a40)\n\t/home/prow/go/pkg/mod/honnef.co/go/[email protected]/staticcheck/lint.go:4271 +0x668\nhonnef.co/go/tools/staticcheck.CheckEvenSliceLength(0xc002cb3a40)\n\t/home/prow/go/pkg/mod/honnef.co/go/[email protected]/staticcheck/lint.go:4509 +0x18\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyze(0xc004358e40)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:195 +0x967\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func2()\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:113 +0x17\ngithub.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc00210b360, {0x17bf943, 0x6}, 0xc002a0a748)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/timeutils/stopwatch.go:111 +0x44\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe(0xc0036b6540?)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:112 +0x6e\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze.func2(0xc004358e40)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_loadingpackage.go:80 +0xa5\ncreated by github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze in goroutine 351\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_loadingpackage.go:75 +0x1e9\n"

@vdemeester do you want to switch this one to the GitHub action too?

Yeah I think so.

@afrittoli
Copy link
Member Author

The linter job is broken here too... :(

level=error msg="[linters_context/goanalysis] SA5012: panic during analysis: interface conversion: interface {} is nil, not *buildir.IR, goroutine 19980 [running]:\nruntime/debug.Stack()\n\t/usr/local/go/src/runtime/debug/stack.go:26 +0x5e\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func1()\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:105 +0x5a\npanic({0x166d980?, 0xc006ea7aa0?})\n\t/usr/local/go/src/runtime/panic.go:785 +0x132\nhonnef.co/go/tools/staticcheck.findSliceLenChecks(0xc002cb3a40)\n\t/home/prow/go/pkg/mod/honnef.co/go/[email protected]/staticcheck/lint.go:4271 +0x668\nhonnef.co/go/tools/staticcheck.CheckEvenSliceLength(0xc002cb3a40)\n\t/home/prow/go/pkg/mod/honnef.co/go/[email protected]/staticcheck/lint.go:4509 +0x18\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyze(0xc004358e40)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:195 +0x967\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func2()\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:113 +0x17\ngithub.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc00210b360, {0x17bf943, 0x6}, 0xc002a0a748)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/timeutils/stopwatch.go:111 +0x44\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe(0xc0036b6540?)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_action.go:112 +0x6e\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze.func2(0xc004358e40)\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_loadingpackage.go:80 +0xa5\ncreated by github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze in goroutine 351\n\t/home/prow/go/pkg/mod/github.com/golangci/[email protected]/pkg/golinters/goanalysis/runner_loadingpackage.go:75 +0x1e9\n"

@vdemeester do you want to switch this one to the GitHub action too?

Yeah I think so.

Can someone from the results team make the change?

@vdemeester
Copy link
Member

Can someone from the results team make the change?

@khrm 🙏🏼

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@khrm
Copy link
Contributor

khrm commented Jan 15, 2025

Sure. I am changing the linter.

@afrittoli
Copy link
Member Author

Sure. I am changing the linter.

Thank you! Let me know if you have any questions- you can check what we did in the plumbing and pipeline repos already for reference, e.g. tektoncd/pipeline#8480

@khrm
Copy link
Contributor

khrm commented Jan 17, 2025

/test pull-tekton-results-build-tests

@khrm
Copy link
Contributor

khrm commented Jan 17, 2025

/test pull-tekton-results-unit-tests

@tekton-robot tekton-robot merged commit 7e58bbf into tektoncd:main Jan 17, 2025
6 checks passed
@khrm
Copy link
Contributor

khrm commented Jan 22, 2025

/cherry-pick release-v0.12.x

@khrm
Copy link
Contributor

khrm commented Jan 22, 2025

/cherry-pick release-v0.13.x

@tekton-robot
Copy link

@khrm: new pull request created: #930

In response to this:

/cherry-pick release-v0.12.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

@khrm: new pull request created: #931

In response to this:

/cherry-pick release-v0.13.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants