fix: Move when condition to higher priority

[Allda]

When using "when" condition in pipelinerun definition we can sometime get into a situation when a task would be skipped due to "when" condition but instead it is skipped either by parent is skipped or result reference is missing. This behaviour has a negative impact on the rest of the tasks in the pipeline.

A good example of this issue is represented by this pipeline:

A -> B -> C

In case B depends on A's result and both A and B uses when condition that both evaluates to false the C is automatically skipped with "Parent Tasks were skipped" even-though C doesn't depend on any previous results.

With this change both A and B are skipped by evaluating the "when" condition and C is executed as expected.

This commit address the bug #7680.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

fix: Move when condition to higher priority

/kind bug

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Allda / name: Aleš Raszka (47b1efc)

[tekton-robot]

Hi @Allda. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[afrittoli]

/ok-to-test

[Allda]

/ok-to-test

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afrittoli]

Thanks for this! It looks good to me

[afrittoli]

/lgtm

[Allda]

@vdemeester @afrittoli Is there anything else needed in this PR or can it be merged?

[afrittoli]

@vdemeester @afrittoli Is there anything else needed in this PR or can it be merged?

Nothing is missing. It's in tide's merge pool now, I'm not sure why it isn't merged yet, let me check tide's logs

[afrittoli]

It's in queue for merge after #8524, but CI was stalling there.
I poked that PR and it seem to have solved the issue.