Skip to content

misc: promote keep-pod-on-cancel to beta #8343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

misc: promote keep-pod-on-cancel to beta #8343

merged 1 commit into from
Apr 24, 2025

Conversation

chengjoey
Copy link
Member

@chengjoey chengjoey commented Oct 23, 2024 •
edited
Loading

Changes

promote keep-pod-on-cancel tobeta

#3238

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

`keep-pod-on-cancel` feature flag will be enabled in default

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2024
@chengjoey
Copy link
Member Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 23, 2024
@chengjoey
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests
/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-beta-integration-tests

@tekton-robot
Copy link
Collaborator

@chengjoey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-integration-tests 142577e link true /test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-beta-integration-tests 142577e link true /test pull-tekton-pipeline-beta-integration-tests
pull-tekton-pipeline-alpha-integration-tests 142577e link true /test pull-tekton-pipeline-alpha-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vdemeester vdemeester added this to the Pipeline v0.69.0 milestone Jan 30, 2025
waveywaves
waveywaves reviewed Mar 25, 2025
View reviewed changes
@vdemeester
Copy link
Member

@chengjoey are you still willing to work on the PR ?

@chengjoey chengjoey changed the title misc: promote keep-pod-on-cancel to default misc: promote keep-pod-on-cancel to beta Mar 29, 2025
@chengjoey
Copy link
Member Author

thanks @waveywaves @vdemeester , pr has been changed to promote keep-pod-on-cancel to beta
and it's default enabled on beta

@waveywaves
Copy link
Member

@chengjoey looking forward to reviewing this again. Seems like you will have to update the e2e tests.
Screenshot 2025-04-01 at 6 24 34 PM

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2025
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2025
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2025
@chengjoey
Copy link
Member Author

@chengjoey looking forward to reviewing this again. Seems like you will have to update the e2e tests. Screenshot 2025-04-01 at 6 24 34 PM

done~

@waveywaves
Copy link
Member

waveywaves commented Apr 7, 2025 •
edited
Loading

@chengjoey this seems good to me. Could you also update the commit message to include why this promotion is being done. This will also close the #3238 issue so having the commit message will help track why the old issue is finally being closed. Apart from that

/approve

@chengjoey chengjoey force-pushed the feat/keep-pod branch 2 times, most recently from 9791b8f to 66165f7 Compare April 7, 2025 12:05
@chengjoey
Copy link
Member Author

@chengjoey this seems good to me. Could you also update the commit message to include why this promotion is being done. This will also close the #3238 issue so having the commit message will help track why the old issue is finally being closed. Apart from that

/approve

done

@chengjoey
Copy link
Member Author

/retest

1 similar comment
@vdemeester
Copy link
Member

/retest

vdemeester
vdemeester approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2025
@tekton-robot tekton-robot merged commit c9ac5b9 into tektoncd:main Apr 24, 2025
31 of 32 checks passed
@chengjoey chengjoey mentioned this pull request Jun 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waveywaves waveywaves waveywaves left review comments

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Done
Milestone
Pipeline v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chengjoey @tekton-robot @vdemeester @waveywaves