-
Notifications
You must be signed in to change notification settings - Fork 166
Add diagnostics where errors/warnings are emitted #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
==========================================
- Coverage 46.13% 45.83% -0.31%
==========================================
Files 138 138
Lines 59956 60445 +489
==========================================
+ Hits 27660 27702 +42
- Misses 32296 32743 +447
Continue to review full report at Codecov.
|
Great, thank you for your submission! I look forward to reviewing. This long weekend I released your first PR in version 0.1.13. I have rebuilt the CI/CD systems and release workflow to be based around a new automation tool that I have spent a long time planning, cranko, so once this PR is merged I plan to get the code released promptly. (I am fine with ignoring the codecov complaints here, given the nature of the changes.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a tour de force! I tried to read everything over and only spotted one very minor item I'd like to request a change for. Great work!
This is a followup of #625 that adds diagnostics to all places in xetex where errors or warnings are emitted (unless I've missed any). This doesn't add any to bibtex or dpx.
I've mainly looked for places
history
(mainlybegin_diagnostic()
)error_here_with_diagnostic
replaceserror()
and related functions