Zero memory upon allocation in bibtex. #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
======================================
Coverage 45.5% 45.5%
======================================
Files 137 137
Lines 59924 59924
======================================
Hits 27268 27268
Misses 32656 32656
Continue to review full report at Codecov.
|
|
Thanks very much! |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue I'm having with memory corruption when calling bibtex multiple times. I have some sample code demonstrating the problem in https://github.com/jneem/tectonic-bibtex-test. Before this patch, running that code reliably produces valgrind warnings (and occasionally crashes). After this patch, it doesn't.