Skip to content

Neaten the dist/travis.sh presentation #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

spl
Copy link
Contributor

@spl spl commented Apr 1, 2019

  • Make the Travis-CI log easier to follow by reducing the noise:
    • put more things behind folds
    • put folds inside if-then blocks to avoid printing '+ false', etc.
    • make fold titles simpler and more consistent
    • avoid printing the values already found in the printed env vars
  • Document the travis_fold usage

* Make the Travis-CI log easier to follow by reducing the noise:
  - put more things behind folds
  - put folds inside if-then blocks to avoid printing '+ false', etc.
  - make fold titles simpler and more consistent
  - avoid printing the values already found in the printed env vars
* Document the travis_fold usage
@pkgw pkgw self-assigned this Apr 1, 2019
@pkgw
Copy link
Collaborator

pkgw commented Apr 1, 2019

I had chosen to put the fold markers outside of the if statements because it helped me understand why certain steps were running, or not running, when I straightened out the Travis infrastructure, but at this point I think the script is a lot better-structured so those markers do seem less necessary.

@pkgw pkgw merged commit d848663 into tectonic-typesetting:master Apr 1, 2019
@spl spl deleted the travis-cleanup branch April 1, 2019 13:46
@spl
Copy link
Contributor Author

spl commented Apr 1, 2019

@pkgw Sure, I understand. You can always add more information to the fold titles if it would help you. I would just recommend making the text more meaningful than true or false so that one doesn't have to look at the script source to figure out what variables are being evaluated to get those values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants