-
Notifications
You must be signed in to change notification settings - Fork 166
Filenames in output should be quoted #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is almost surely a small Rust crate out there that implements the algorithm of taking a number of bytes and textifying it as |
@pkgw I'm really busy at the moment, but if someone doesn't get around to this in the next 2-3 weeks I should be able to do this! (Feel free to ping me around then.) |
Can this be closed? Looks like a fix has been merged. |
Sure! We can always reopen, or make a new issue, if there's more to do. |
Thanks, glad to see this has been fixed! |
Addresses issue tectonic-typesetting#539 - Paths and filenames are now quoted in backticks - File sizes are now expressed in appropriate units (KiB/MiB) This adds a new dependency (byte-unit) for expressing file sizes.
This is motivated by the fact I get output like the following in the
LaTeX Compiler
log window in VSCode:and only
/Users/alex/Documents/A
gets highlighted as a filename. In any case, the general practice is to enclose filenames in console output as`/a/b/c`
, I believe. This would solve the issue.I don't know if it covers all cases, but the
note_highlighted
fn (second parameter) seems to be responsible for this sort of printing. The enclosing of filenames in backticks is probably best done at call-site however (using a helper function?).While I'm writing this, a bonus would be comma-separating the number of bytes, e.g.,
123,456,789 bytes
-- or better yet,123 MB
(alsokB
andB
of course). All for readability of course, since this is nitpicking!The text was updated successfully, but these errors were encountered: