-
-
Notifications
You must be signed in to change notification settings - Fork 21
next: Svelte 5 #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next: Svelte 5 #458
Conversation
🦋 Changeset detectedLatest commit: 5ca5943 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit: |
…Points within Labels requires function accessor to return explicit value instead of being interrupted as index value)
… a frozen processor" (will look at later or switch to mdsx)
…pdate `createHighlightKey()` and `createSeriesState()` to be class-based `HighlightKey` and `SeriesState`
…l update @layerstack/svelte-actions impl (event callbacks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huntabyte amazing work! Releasing as 2.0.0-next.2
and we'll continue to iterate as we move towards a 2.0.0
release
WIP - exploration into what a next-generation API may look like for LayerChart, taking full advantage of Svelte 5.
Closes #7
Closes #112
Closes #159
Closes #261
Closes #291
Closes #451
Closes #456
Closes #469
Closes #472
Closes #480
pnpm check
(svelte-check) failuresBarChart
,LineChart
,PieChart
uniqueId
with$props.id()
and a newcreateId
function to create multiple unique ids based off of the single$props.id()
Legend
component should be more composable. Right now if you opt into the included legend via one of the simplfiied charts, you get a bunch of great functionality. The data required for that functionality should be provided via a snippet prop to thelegend
snippet in those components.<BarChart>
and the resulting Bars end up being<Rect>
s instead of<Spline>
the tween configuration doesn't align causing unexpected behavior. Would be nice if we could normalize this so thatBarChart.props.bars.tweened = true
works the same as it does when there aren't all/no rounded corners.tickLength specifies how long the tick line itself is, but has no effect on the tickLabel, if this is by design then there should be a way to move the label over as wellI've since discovered you can accomplish this viaprops.xAxis.tickLabelProps.svgProps
but it feels like a lot of work and not the greatest DX for something simple.Determine how to round the radius of specific corners of stacked bar charts.using theseries[0].props
did the trick 😃value
prop exposed on labels, we also expose acolor:
which could either be hard coded or an accessor.<BarChart>
,<AreaChart>
,<LabelChart>
, etc., but the only way to access it is to opt-out of the work it does for you by using thechildren
snippet. We should expose that information via a bindable prop as well.series
to take advantage of them? What if we just build it for them in absense of one, using the accessor value as the key and then the rest of the data as usual?Points
/Labels
to account for x1 scales (i.e grouped by charts) likeBars
. (issue)selectionState
anduniqueState
to@layerstack/svelte-state
BrushContext
to support band scales<ArcChart>
and<BarChart radial orientation="horizontal">
stackExpand
)aboveMarks
instead ofaboveContext
)asAny()
usageExample A
CleanShot.2025-03-23.at.00.27.08.mp4
Regressions
Collision Detection
BrushContext
null
in use caseBarChart