Implement a --show-app CLI flag #751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ability for the window to focus an app's page for a given appId string. If no match is found, nothing happens
Adds a function to parse and handle command-line arguments and flags. Currently there are no flags to handle yet
Adds a --show-app flag, which takes a string for the appId of a Flatpak. This then runs the window's showAppId function to try and show the matching app
|
hey @heliguy4599 , I will take a look at this ASAP. Thanks. |
|
Great to hear! You're welcome, and thank you for this wonderful app itself! |
tchx84
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Apologies for the big delay.
This looks OK, but wouldn't it better to expose this functionality as a service?
So that, instead of having to call flatseal via CLI (which is an unlikely use case for actual people), one could simply activate Flatseal with the proper appId via DBus (which is what programs should be doing, like your use case).
I am pretty sure there is a GApplication/GAction magic that does all the heavy lifting here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this adds:
flatseal --show-app org.app.NameThere is no way to show the Global section, however I can add this if it is desired. Also, I can change the behavior of a non-matching provided ID, if you'd like that to behave differently than doing nothing.
The new flag shows up in the default --help output, with a description.
I believe I have followed Flatseal's coding style to the best of my abilities, but I can always refine what I've added!
Why I think this should be added:
I believe it would be handy for Flatseal to be able to be opened to a specific application, to allow it to be called from other apps or scripts. I am the developer of Warehouse, and I would like to be able to launch Flatseal to a specific app via a button in the UI.