Skip to content

Update external users feature #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 17, 2025
Merged

Update external users feature #57

merged 20 commits into from
Jul 17, 2025

Conversation

yostyle
Copy link

@yostyle yostyle commented Jul 11, 2025 •
edited by raphael-chevallier
Loading

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@yostyle yostyle changed the title Update external user feature Update external users feature Jul 11, 2025
@raphael-chevallier raphael-chevallier force-pushed the yostyle/external_users_rebased_25070 branch from 573c830 to 55e8a46 Compare July 16, 2025 10:08
@raphael-chevallier raphael-chevallier force-pushed the yostyle/external_users_rebased_25070 branch from 55e8a46 to 8ee4875 Compare July 16, 2025 10:19
@raphael-chevallier raphael-chevallier force-pushed the yostyle/external_users_rebased_25070 branch 4 times, most recently from cdaecb2 to 7acc2b9 Compare July 16, 2025 17:31
@raphael-chevallier raphael-chevallier force-pushed the yostyle/external_users_rebased_25070 branch from 7acc2b9 to eb4d77b Compare July 17, 2025 08:54
@raphael-chevallier raphael-chevallier marked this pull request as ready for review July 17, 2025 09:13
NicolasBuquet
NicolasBuquet requested changes Jul 17, 2025
View reviewed changes
Copy link

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make annotation when using lfs: true about the temporary solution to embed aar lib.

@raphael-chevallier raphael-chevallier force-pushed the yostyle/external_users_rebased_25070 branch from 8ba38bc to dfd281e Compare July 17, 2025 15:12
@raphael-chevallier raphael-chevallier added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 17, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 17, 2025
NicolasBuquet
NicolasBuquet approved these changes Jul 17, 2025
View reviewed changes
Copy link

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphael-chevallier raphael-chevallier merged commit e7814d6 into develop Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphael-chevallier raphael-chevallier raphael-chevallier left review comments

@NicolasBuquet NicolasBuquet NicolasBuquet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yostyle @raphael-chevallier @NicolasBuquet @ElementBot