Skip to content

fix(content-scanning): use devicePixelRatio in thumbnails dimensions #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix(content-scanning): use devicePixelRatio in thumbnails dimensions #927

merged 1 commit into from
Mar 5, 2024

Conversation

revolunet
Copy link
Contributor

@revolunet revolunet commented Mar 4, 2024 •
edited by estellecomment
Loading

@odelcroi odelcroi marked this pull request as ready for review March 5, 2024 10:06
@estellecomment estellecomment reopened this Mar 5, 2024
@revolunet
Copy link
Contributor Author

je vais refaire une passe en comparant à cette modif côté react-sdk: matrix-org/matrix-react-sdk@915f8b3

@estellecomment
Copy link
Contributor

added review app manually, it will not auto-create from a fork (in scalingo : go to main app, then : review apps > manual deployment)

@revolunet
Copy link
Contributor Author

LGTM

@estellecomment
Copy link
Contributor

je vais refaire une passe en comparant à cette modif côté react-sdk: matrix-org/matrix-react-sdk@915f8b3

Prends en compte le fait qu'on va recupérer ce code, qui a l'air d'etre dans matrix-react-sdk v3.93.0, dans une prochaine upgrade. Du coup je suis pas sure que ca soit pertinent... Peut etre que ca va casser à la prochaine upgrade d'element...

@estellecomment
Copy link
Contributor

Testé sur la review app : ca marche pour l'avatar en haut à gauche, et les avatars sur un message dans une conversation.

Cool on merge ca :) Merci bcp pour ta participation @revolunet ❤️

@estellecomment estellecomment merged commit 1a913a5 into tchapgouv:develop_tchap Mar 5, 2024
@revolunet
Copy link
Contributor Author

trop cool ! merci @estellecomment pour ta guidance !!

on sait combien d'users sur Mac seront impactés ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estellecomment estellecomment estellecomment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Room avatars are blurry
2 participants
@revolunet @estellecomment