Run build.yml and cypress.yml on all PR commits #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estellecomment
changed the title
|
Merging without review, to see if it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like the less shitty option.
Run the two jobs for all commits, and then add "if: github.event.pull_request.draft == false/true" to filter which of the two should run.
When you change the status of the PR from draft to non-draft (or non-draft to draft), just close and reopen the PR to have the other job run.
Hopefully this is the last PR I do on this.
The previous trigger "pull_request: types: [ready_for_review]" didn't work because it ran ONLY when the status changed to ready for review.