Skip to content

Remove useless cypress plugins #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 15, 2023

Conversation

estellecomment
Copy link
Contributor

@estellecomment estellecomment commented Sep 28, 2023

We had copied element's setup a bit blindly, and added several plugins that we are actually not using.
I'm going towards keeping things simple, so that we actually understand our own code.
That might speed things up, who knows.

It's also a move towards importing react-sdk's helper functions (e.g "cy.openUserSettings"), rather than copying them, because the latest helpers are in sync with the latest app code. So no breaks on element-web upgrades.

  • remove code we don't use
  • remove dependencies we don't use
  • add a readme to explain that react-sdk's files can be helpful, and other tips on how to write tests

@estellecomment estellecomment marked this pull request as draft September 28, 2023 16:19
@estellecomment estellecomment marked this pull request as ready for review September 28, 2023 16:19
@estellecomment estellecomment changed the title [do not merge] Remove useless cypress plugins Remove useless cypress plugins Nov 3, 2023
@estellecomment estellecomment marked this pull request as draft November 3, 2023 11:48
@estellecomment estellecomment marked this pull request as ready for review November 7, 2023 15:19
@estellecomment estellecomment merged commit 395e61e into develop_tchap Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant