Skip to content

add room header when externals are allowed #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 20, 2022

Conversation

odelcroi
Copy link
Member

@odelcroi odelcroi commented Oct 18, 2022

With the header :
Capture d’écran 2022-10-18 à 16 30 24

Test :

  • 1 : create a room with external allowed, check that the header is displayed
  • 2 : create a private room without external allowed, check that the header is NOT displayed
  • 3 : create a private room, after the creation, allow external in the settings, check that the header is displayed

e2e :

  • 1 : create a room with external allowed, check that the header is displayed
  • 2 : create a private room without external allowed, check that the header is NOT displayed

UI :

  • : check responsiveness -> N/A

@odelcroi odelcroi marked this pull request as draft October 18, 2022 14:32
@odelcroi odelcroi linked an issue Oct 18, 2022 that may be closed by this pull request
@odelcroi odelcroi marked this pull request as ready for review October 19, 2022 12:59
@odelcroi odelcroi marked this pull request as draft October 19, 2022 13:05
@odelcroi odelcroi marked this pull request as ready for review October 19, 2022 13:16
room?: Room;
}

export function checkExternalAllowed(room: Room): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je mettrais bien cette fonction dans TchapRoomUtils

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si tu veux :)

@estellecomment
Copy link
Contributor

cypress is broken locally and in CI, but I can't figure out why. Later.

@estellecomment estellecomment force-pushed the 184-are-external-users-allowed-in-room branch from d8c5604 to f949eae Compare October 20, 2022 08:44
@odelcroi odelcroi merged commit 186c422 into develop_tchap Oct 20, 2022
@odelcroi odelcroi deleted the 184-are-external-users-allowed-in-room branch March 31, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roomlist displays private and public rooms in the same way
2 participants