Skip to content

Element's CI checks are broken #65

Closed
@estellecomment

Description

@estellecomment

Our tchap customisation files break some of element's CI checks on PRs. See for example : #62

  • type check : our files contain sdk.getComponent instead of imports (which seem not to work in customisations), and getComponent is not found.
  • i18n check : our files add custom translations, which we implement in tchap_translations.json, to keep them cleanly separated from element's translations and avoid merge problems and lost translations. Therefore, the translation checker fails because it sees missing strings in en_EN.json (because we have placed them in tchap_translations.json instead)

Would be nice to have a working translation check, at least...

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions