merge immutable-arraybuffer tests #4445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 tasks
gibson042
reviewed
Apr 4, 2025
There was a problem hiding this comment.
@phoddie This is pretty noisy right now; please fix the lint issues:
- Add necessary front matter fields
- Update features.txt
- Fix the copyrights to a single year rather than a range
- etc.
|
Sure, will do. FWIW – "Fix the copyrights to a single year rather than a range" feels artificial. |
|
It's not; it ensures that the range doesn't need to be updated every year. |
|
Rebasing on main will also get the annotation improvements from #4449. |
??? The range only needs to be updated in years when the tests are modified, not when the calendar advances. Anyway. I will change the tests to conform with this peculiar requirement. |
|
The linter is now happy and I've attempted to resolve all comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suite of test262 tests for the Immutable ArrayBuffer proposal.