Skip to content

Normative: Fix typo in ToTemporalMonthDay #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

Aditi-1400
Copy link
Collaborator

Fixes: #2457

@Aditi-1400 Aditi-1400 requested a review from ptomato January 6, 2023 14:14
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #2460 (509102b) into main (86d42de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2460   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          20       20           
  Lines       11285    11285           
  Branches     2163     2163           
=======================================
  Hits        10852    10852           
  Misses        369      369           
  Partials       64       64           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'll mark this as draft until presented at TC39.

The reference code already works this way, but we should make sure this is covered by test262 tests as well.

@ptomato ptomato marked this pull request as ready for review April 18, 2023 19:11
@ptomato
Copy link
Collaborator

ptomato commented Apr 18, 2023

This normative change reached consensus in the March 2023 TC39 meeting. Test262 tests are in tc39/test262#3818

@ptomato ptomato merged commit 1aa6b80 into tc39:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in ToTemporalMonthDay
2 participants