Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: channel callback never cleaned up from window #13136

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Apr 4, 2025

Fix #13133

Also:

  • added a feature that allows passing the callback as the parameter of constructor of Channel so you can use it like this new Channel((message) => console.log(message))
  • only go through the fetch process if the data is large enough for it to be faster

Copy link
Contributor

github-actions bot commented Apr 4, 2025

Package Changes Through 7431e00

There are 3 changes which include @tauri-apps/api with minor, tauri with minor, tauri-runtime with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.4.1 2.5.0
tauri-runtime 2.5.1 2.6.0
tauri-runtime-wry 2.5.1 2.5.2
tauri 2.4.1 2.5.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master Legend-Master marked this pull request as ready for review April 5, 2025 04:37
@Legend-Master Legend-Master requested a review from a team as a code owner April 5, 2025 04:37
@Legend-Master
Copy link
Contributor Author

This change will require syncing the version of rust crate tauri and js package @tauri-apps/api, since this is marked as a minor I think we can do this right?

@FabianLars
Copy link
Member

hmm, yeah. we've communicated that minor versions are synced a few times (even if we don't fully follow it) so it should be fine. not the first time in 2.x either 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📬Proposal
Development

Successfully merging this pull request may close these issues.

[bug] Listening to Tauri channel events creates memory leak
2 participants