-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support custom CFBundleVersion for iOS and macOS #13030
base: dev
Are you sure you want to change the base?
Conversation
b0eb392
to
7db9c76
Compare
@lucasfernog @FabianLars PR has been rebased and is ready for review. |
Package Changes Through 9fcab1dThere are 2 changes which include tauri with minor, tauri-runtime with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
20cac59
to
b1b76f2
Compare
23be458
to
968c350
Compare
4472061
to
9fcab1d
Compare
@FabianLars Just rebased the PR. I was seeing an unrelated CI failure for Linux but should be resolved by running again. |
@FabianLars Looks like it's still happening with the Ubuntu runner:
|
do you mean the android ones? just ignore them, idk why it fails but since nothing in your pr touches android stuff and it also fails in other prs i won't require it to be resolved for this to get merged 🤷 |
This PR resolves #12479 and adds support for specifying a custom
CFBundleVersion
for iOS and macOS.It allows a custom build number to be injected i.e. from CI and used in
Info.plist
when building an application bundle.Specifically this resolves the issue where multiple builds cannot be submitted to TestFlight for a single version i.e. 1.0.0 (1), 1.0.0 (2) which is a blocking issue for CI/CD automation. It follows the same approach used for specifying
versionCode
for Android and adds a new bundle configuration property for iOS and macOS:bundleVersion
.See PR 3216 with related documentation changes.
cc: @lucasfernog