fix: channel callback never cleaned up from window
#13136
Conversation
Package Changes Through e54daa9There are 5 changes which include @tauri-apps/api with minor, tauri with minor, tauri-bundler with patch, tauri-runtime with minor, tauri-runtime-wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
This change will require syncing the version of rust crate |
|
hmm, yeah. we've communicated that minor versions are synced a few times (even if we don't fully follow it) so it should be fine. not the first time in 2.x either 🤷 |
| "window.__TAURI_INTERNALS__.invoke('{FETCH_CHANNEL_DATA_COMMAND}', null, {{ headers: {{ '{CHANNEL_ID_HEADER_NAME}': '{data_id}' }} }}).then((response) => window['_' + {}]({{ message: response, id: {i} }})).catch(console.error)", | ||
| callback_id.0 | ||
| ))?; | ||
| // Don't go through the fetch process if the payload is small |
There was a problem hiding this comment.
finally someone who agrees with me on that approach 😂
There was a problem hiding this comment.
This should significantly reduce the load in places like sending updater's download progress
Fix #13133
Also:
Channelso you can use it like thisnew Channel((message) => console.log(message))