Open Menu and Listbox on mousedown
#3689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a normal `click`, the flow goes like this: 1. mousedown 2. focus 3. mouseup 4. click But now that we use `mousedown` with an `event.preventDefault()`, we will also cancel the `focus` event and therefore the `onFocus` won't fire at all.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A normal `click` handles that for you, but a mousedown does not. Let's only allow a normal left click only.
RobinMalfait
force-pushed
the
change/trigger-elements-on-mousedown
branch
from
a7aac95 to
9136265
Compare
thecrypticace
approved these changes
Apr 10, 2025
|
This caused a bug in my UI—I’m reverting my project to use 2.2.1 in the meantime. I started a discussion here: #3714 |
|
To whom it may concern : |
|
It makes so bad. When user tries to scroll on mobile devices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small behavioral change, but this PR will change when the
MenuandListboxcomponents open.This PR will now open the
MenuandListboxcomponents onmousedowninstead ofclick. This will make it feel more responsive and faster to the user.This is also how macOS for example opens menu-like components on the OS level. This is also how the native
<select>(at least on macOS) works.