Fix Unexpected undefined crash in Combobox component with virtual mode
#3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already verify that the `activeOptionIndex` is inside the `options` before we call the `virtualizer.scrollToIndex` function. However, if you do this when the virtualizer isn't ready internally yet, then you get an error like `unexpected undefined`. Found an open issue on their GitHub: TanStack/virtual#879 Don't know if there is a better fix we can apply here, but delaying the `scrollToIndex` does seem to fix the problem. Another thing I tried is waiting for the DOM to be ready, but we already only run this code _if_ the DOM `el` is available.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecrypticace
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
Comboboxcomponent crashes if you are using thevirtualoption and you quickly type something such that theComboboxopens but no valid options are available.We already check if the current active index is available in the internal
optionslist. However, if you then callvirtualizer.scrollToIndex(data.activeOptionIndex)it will crash if you are too fast.Screen.Recording.2025-04-04.at.12.53.40.mov
If you are typing slowly, then it will work as expected.
Screen.Recording.2025-04-04.at.12.54.01.mov
I did find an open issue on TanStack's repo about this: TanStack/virtual#879
This PR is basically a workaround by delaying the call. But it does have the expected behavior now.
Screen.Recording.2025-04-04.at.12.57.40.mov
Fixes: #3583