Skip to content

chore(taiko-client): cleanup the Ontake fork decompression method #19528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2025

Conversation

davidtaikocha
Copy link
Contributor

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up the decompression method by removing the deprecated DecompressPacaya function and updating the Decompress function's error handling.

  • Removed DecompressPacaya and associated test cases.
  • Updated calls in driver files to use the unified Decompress method.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/taiko-client/pkg/utils/utils.go Updated Decompress function; removed DecompressPacaya function and comment adjustments.
packages/taiko-client/pkg/utils/util_test.go Removed tests for the deprecated DecompressPacaya function.
packages/taiko-client/driver/txlist_decompressor/txlist_decompressor.go Updated to call Decompress instead of DecompressPacaya.
packages/taiko-client/driver/preconf_blocks/server.go Updated to call Decompress instead of DecompressPacaya.
packages/taiko-client/driver/chain_syncer/event/blocks_inserter/pacaya.go Updated to call Decompress instead of DecompressPacaya.
Comments suppressed due to low confidence (1)

packages/taiko-client/pkg/utils/utils.go:116

  • The documentation for Decompress indicates handling of ErrUnexpectedEOF, but the implementation only checks for io.EOF. Update the error check to also consider io.ErrUnexpectedEOF or adjust the comment to accurately reflect the behavior.
if err != nil {

Copy link

codecov bot commented May 24, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.40%. Comparing base (0c4bd86) to head (c855d12).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...river/chain_syncer/event/blocks_inserter/pacaya.go 0.00% 1 Missing ⚠️
...kages/taiko-client/driver/preconf_blocks/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
.../driver/txlist_decompressor/txlist_decompressor.go 100.00% <100.00%> (ø)
packages/taiko-client/pkg/utils/utils.go 30.30% <ø> (-1.84%) ⬇️
...river/chain_syncer/event/blocks_inserter/pacaya.go 0.00% <0.00%> (ø)
...kages/taiko-client/driver/preconf_blocks/server.go 9.98% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c4bd86...c855d12. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidtaikocha davidtaikocha added this pull request to the merge queue May 24, 2025
Merged via the queue into main with commit e30687c May 24, 2025
9 checks passed
@davidtaikocha davidtaikocha deleted the remove-unused-decompress branch May 24, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants