Skip to content

fix(taiko-client): reduce slot required for updating lookahead #19526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2025
Merged

fix(taiko-client): reduce slot required for updating lookahead #19526

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fe6b15
comment
cyberhorsey May 23, 2025
2934686
only push slot ranges if the operator actually us
cyberhorsey May 24, 2025
d2b79c1
Merge branch 'main' into lookahead_change_slot_in_epoch
cyberhorsey May 24, 2025
20b3652
Merge branch 'main' into lookahead_change_slot_in_epoch
davidtaikocha May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 49 additions & 19 deletions packages/taiko-client/driver/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,26 +457,56 @@ func (d *Driver) cacheLookaheadLoop() {
// once per epoch, since we push the next operator as the current range when we check.
// so, this means we should use a reliable slot past 0 where the operator has no possible
// way to change. mid-epooch works, so we use slot 16.
if lookahead == nil || lookahead.LastEpochUpdated < currentEpoch && slotInEpoch >= 15 {
log.Info(
"Pushing into window for current epoch",
"epoch", currentEpoch,
"currentSlot", currentSlot,
"slotInEpoch", slotInEpoch,
"currOp", currOp.Hex(),
"nextOp", nextOp.Hex(),
)
opWin.Push(currentEpoch, currOp, nextOp)
if lookahead == nil || lookahead.LastEpochUpdated < currentEpoch && slotInEpoch >= 2 {
if currOp == d.PreconfOperatorAddress && nextOp == d.PreconfOperatorAddress {
log.Info(
"Pushing into window for current epoch as current and next operator",
"epoch", currentEpoch,
"currentSlot", currentSlot,
"slotInEpoch", slotInEpoch,
"currOp", currOp.Hex(),
"nextOp", nextOp.Hex(),
)
opWin.Push(currentEpoch, currOp, nextOp)

// Push next epoch into window.
log.Info(
"Pushing into window for next epoch",
"epoch", currentEpoch+1,
"currentSlot", currentSlot,
"slotInEpoch", slotInEpoch,
"currOp", nextOp.Hex(), // currOp becomes nextOp at next epoch
)
opWin.Push(currentEpoch+1, nextOp, common.Address{}) // We don't know next-next-op, safe to leave zero
log.Info(
"Pushing into window for next epoch as current operator",
"epoch", currentEpoch+1,
"currentSlot", currentSlot,
"slotInEpoch", slotInEpoch,
"currOp", nextOp.Hex(),
)
opWin.Push(currentEpoch+1, nextOp, common.Address{}) // next next op is safe to leave 0
} else if currOp == d.PreconfOperatorAddress {
log.Info(
"Pushing into window for current epoch as current operator",
"epoch", currentEpoch,
"currentSlot", currentSlot,
"slotInEpoch", slotInEpoch,
"currOp", currOp.Hex(),
"nextOp", nextOp.Hex(),
)
opWin.Push(currentEpoch, currOp, common.Address{})
} else if nextOp == d.PreconfOperatorAddress {
log.Info(
"Pushing into window for current epoch as next operator",
"epoch", currentEpoch,
"currentSlot", currentSlot,
"slotInEpoch", slotInEpoch,
"currOp", currOp.Hex(),
"nextOp", nextOp.Hex(),
)
opWin.Push(currentEpoch, common.Address{}, nextOp)

log.Info(
"Pushing into window for next epoch as current operator",
"epoch", currentEpoch+1,
"currentSlot", currentSlot,
"slotInEpoch", slotInEpoch,
"currOp", nextOp.Hex(),
)
opWin.Push(currentEpoch+1, nextOp, common.Address{}) // next next op is safe to leave 0
}

var (
currRanges = opWin.SequencingWindowSplit(d.PreconfOperatorAddress, true)
Expand Down