Skip to content

feat(taiko-client): add more preconfirmation metrics #19523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2025

Conversation

davidtaikocha
Copy link
Contributor

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds more preconfirmation metrics to enhance observability of driver events in the Taiko client. Key changes include the addition of several new gauges and counters in the metrics package, updates to API calls to record events, and consistent renaming of existing metrics to remove outdated "P2P" prefixes.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/taiko-client/internal/metrics/metrics.go Adds several new metric definitions and renames some existing metrics to improve naming consistency.
packages/taiko-client/driver/preconf_blocks/server.go Updates calls to use the new metric names and registers new events.
packages/taiko-client/driver/preconf_blocks/queue.go Adds a metric call for caching envelope events.
packages/taiko-client/driver/preconf_blocks/api.go Records a new metric when building preconfirmation blocks from RPC data.
Comments suppressed due to low confidence (1)

packages/taiko-client/driver/preconf_blocks/api.go:236

  • [nitpick] Verify that using a Gauge for counting blocks from RPC is intentional; if the value only ever increases, a Counter might be more semantically appropriate.
metrics.DriverL2PreconfBlocksFromRPCGauge.Inc()

Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 26.55%. Comparing base (e7b8f05) to head (9cd6243).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...kages/taiko-client/driver/preconf_blocks/server.go 0.00% 18 Missing ⚠️
packages/taiko-client/driver/preconf_blocks/api.go 0.00% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...ckages/taiko-client/driver/preconf_blocks/queue.go 81.48% <100.00%> (+0.23%) ⬆️
packages/taiko-client/internal/metrics/metrics.go 0.00% <ø> (ø)
packages/taiko-client/driver/preconf_blocks/api.go 0.00% <0.00%> (ø)
...kages/taiko-client/driver/preconf_blocks/server.go 9.98% <0.00%> (-0.16%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b8f05...9cd6243. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidtaikocha davidtaikocha enabled auto-merge May 23, 2025 11:08
@davidtaikocha davidtaikocha added this pull request to the merge queue May 24, 2025
Merged via the queue into main with commit b599ffe May 24, 2025
10 of 11 checks passed
@davidtaikocha davidtaikocha deleted the more-preconf-metrics-3 branch May 24, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants