-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(taiko-client): introduce BuildPayloadArgsID
for L1Origin
#19444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new BuildPayloadArgsID for L1Origin while updating batch verification logic by renaming functions and modifying error messages for clarity.
- Rename and update preconfirmation checks to known canonical batch/block checks.
- Introduce BuildPayloadArgs construction with a generated BuildPayloadArgsID.
- Update dependency versions in go.mod to use the new taiko-geth reference.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/taiko-client/driver/chain_syncer/event/blocks_inserter/pacaya.go | Introduces BuildPayloadArgs usage and updates comments for clarity. |
packages/taiko-client/driver/chain_syncer/event/blocks_inserter/common.go | Renames functions and updates verification logic and error messages. |
go.mod | Updates dependency reference for go-ethereum to a newer version. |
Comments suppressed due to low confidence (1)
packages/taiko-client/driver/chain_syncer/event/blocks_inserter/common.go:300
- [nitpick] The error message in the block below (lines 302-306) may be misleading. Since the condition means that the block is already in the canonical chain, consider revising the error message to indicate that the block is already canonical rather than implying a mismatch.
if l1Origin.BuildPayloadArgsID != [8]byte{} && l1Origin.BuildPayloadArgsID == id {
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ref: taikoxyz/taiko-geth#426