Skip to content

feat(taiko-client): introduce BuildPayloadArgsID for L1Origin #19444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 13, 2025

Conversation

davidtaikocha
Copy link
Contributor

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new BuildPayloadArgsID for L1Origin while updating batch verification logic by renaming functions and modifying error messages for clarity.

  • Rename and update preconfirmation checks to known canonical batch/block checks.
  • Introduce BuildPayloadArgs construction with a generated BuildPayloadArgsID.
  • Update dependency versions in go.mod to use the new taiko-geth reference.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/taiko-client/driver/chain_syncer/event/blocks_inserter/pacaya.go Introduces BuildPayloadArgs usage and updates comments for clarity.
packages/taiko-client/driver/chain_syncer/event/blocks_inserter/common.go Renames functions and updates verification logic and error messages.
go.mod Updates dependency reference for go-ethereum to a newer version.
Comments suppressed due to low confidence (1)

packages/taiko-client/driver/chain_syncer/event/blocks_inserter/common.go:300

  • [nitpick] The error message in the block below (lines 302-306) may be misleading. Since the condition means that the block is already in the canonical chain, consider revising the error message to indicate that the block is already canonical rather than implying a mismatch.
if l1Origin.BuildPayloadArgsID != [8]byte{} && l1Origin.BuildPayloadArgsID == id {

Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.

Project coverage is 35.02%. Comparing base (5056a5a) to head (895e7fd).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...river/chain_syncer/event/blocks_inserter/common.go 79.48% 5 Missing and 3 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...river/chain_syncer/event/blocks_inserter/pacaya.go 70.46% <100.00%> (+1.34%) ⬆️
...river/chain_syncer/event/blocks_inserter/common.go 75.42% <79.48%> (+9.64%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b481c7...895e7fd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cyberhorsey cyberhorsey self-requested a review May 13, 2025 17:36
@cyberhorsey cyberhorsey added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit 883a356 May 13, 2025
9 checks passed
@cyberhorsey cyberhorsey deleted the BuildPayloadArgsID branch May 13, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants