-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(taiko-client): improve FetchPacaya
#19438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to improve the behavior of the FetchPacaya function in the Taiko client. The key change is the addition of a break statement immediately after appending bytes, which alters the loop's logic to exit early.
- Exits the loop after appending the first set of bytes.
- Enhances the control flow within the FetchPacaya function.
Co-authored-by: Copilot <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good!
Co-authored-by: Copilot <[email protected]>
No description provided.