Skip to content

feat(taiko-client): improve FetchPacaya #19438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

feat(taiko-client): improve FetchPacaya #19438

merged 2 commits into from
May 12, 2025

Conversation

davidtaikocha
Copy link
Contributor

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve the behavior of the FetchPacaya function in the Taiko client. The key change is the addition of a break statement immediately after appending bytes, which alters the loop's logic to exit early.

  • Exits the loop after appending the first set of bytes.
  • Enhances the control flow within the FetchPacaya function.

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.61%. Comparing base (3580ac1) to head (4e2b931).
Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
...ackages/taiko-client/driver/txlist_fetcher/blob.go 65.00% <100.00%> (+0.71%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e634dcc...4e2b931. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good!

@davidtaikocha davidtaikocha added this pull request to the merge queue May 12, 2025
Merged via the queue into main with commit e903eec May 12, 2025
9 checks passed
@davidtaikocha davidtaikocha deleted the fix-FetchPacaya branch May 12, 2025 09:41
davidtaikocha added a commit that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants