Skip to content

chore(taiko-client): remove an unused filed in PreconfBlockAPIServer #19386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2025

Conversation

davidtaikocha
Copy link
Contributor

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused handoverSlots field from PreconfBlockAPIServer and updates related constructors and tests accordingly.

  • Removed the handoverSlots field from the PreconfBlockAPIServer struct and its associated parameter in the New function.
  • Removed the assignment of handoverSlots in the test suite and the argument passed in driver.go.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/taiko-client/driver/preconf_blocks/server_test.go Removed assignment of handoverSlots from tests to reflect changes.
packages/taiko-client/driver/preconf_blocks/server.go Removed the unused field and parameter related to handoverSlots.
packages/taiko-client/driver/driver.go Updated the constructor call to remove the handoverSlots argument.
Comments suppressed due to low confidence (3)

packages/taiko-client/driver/preconf_blocks/server.go:63

  • The removal of the unused handoverSlots field improves clarity. Please ensure that any documentation referencing this field is also updated accordingly.
-	handoverSlots                 uint64

packages/taiko-client/driver/preconf_blocks/server.go:70

  • Removing the handoverSlots parameter from the New function aligns with the refactoring; consider updating function comments or documentation if they mention this parameter.
-	handoverSlots uint64,

packages/taiko-client/driver/driver.go:120

  • The update in driver.go correctly removes the unused handoverSlots argument; please verify that d.PreconfHandoverSkipSlots is no longer used elsewhere in the codebase.
-	d.PreconfHandoverSkipSlots,

Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.80%. Comparing base (bb54d0c) to head (f735f58).
Report is 30 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
packages/taiko-client/driver/driver.go 19.06% <ø> (-0.26%) ⬇️
...kages/taiko-client/driver/preconf_blocks/server.go 17.69% <ø> (-0.23%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d0329...f735f58. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidtaikocha davidtaikocha added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit d8f6a17 May 9, 2025
9 checks passed
@davidtaikocha davidtaikocha deleted the remove-handover-slots branch May 9, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants