-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore(taiko-client): remove an unused filed in PreconfBlockAPIServer
#19386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the unused handoverSlots field from PreconfBlockAPIServer and updates related constructors and tests accordingly.
- Removed the handoverSlots field from the PreconfBlockAPIServer struct and its associated parameter in the New function.
- Removed the assignment of handoverSlots in the test suite and the argument passed in driver.go.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/taiko-client/driver/preconf_blocks/server_test.go | Removed assignment of handoverSlots from tests to reflect changes. |
packages/taiko-client/driver/preconf_blocks/server.go | Removed the unused field and parameter related to handoverSlots. |
packages/taiko-client/driver/driver.go | Updated the constructor call to remove the handoverSlots argument. |
Comments suppressed due to low confidence (3)
packages/taiko-client/driver/preconf_blocks/server.go:63
- The removal of the unused handoverSlots field improves clarity. Please ensure that any documentation referencing this field is also updated accordingly.
- handoverSlots uint64
packages/taiko-client/driver/preconf_blocks/server.go:70
- Removing the handoverSlots parameter from the New function aligns with the refactoring; consider updating function comments or documentation if they mention this parameter.
- handoverSlots uint64,
packages/taiko-client/driver/driver.go:120
- The update in driver.go correctly removes the unused handoverSlots argument; please verify that d.PreconfHandoverSkipSlots is no longer used elsewhere in the codebase.
- d.PreconfHandoverSkipSlots,
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
No description provided.