Skip to content

feat(taiko-client): lookahead sliding window #19322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Apr 26, 2025
Merged

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Apr 22, 2025

instead of using slots ,which can be missed, we instead use a sliding window, keeping track of ranges.

@davidtaikocha @YoGhurt111 wait to merge until I've confirmed it works fully as expected, then I will remove the build step from this PR. It's currently running.

edit: It works! Merging.

@davidtaikocha davidtaikocha disabled auto-merge April 24, 2025 03:28
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 64.66165% with 47 lines in your changes missing coverage. Please review.

Project coverage is 38.81%. Comparing base (d6001d3) to head (d921918).
Report is 1081 commits behind head on main.

Files with missing lines Patch % Lines
packages/taiko-client/driver/driver.go 0.00% 39 Missing ⚠️
packages/taiko-client/driver/config.go 62.50% 2 Missing and 1 partial ⚠️
...kages/taiko-client/driver/preconf_blocks/server.go 90.47% 1 Missing and 1 partial ⚠️
packages/taiko-client/pkg/rpc/client.go 71.42% 2 Missing ⚠️
packages/taiko-client/driver/preconf_blocks/api.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...es/taiko-client/driver/preconf_blocks/lookahead.go 100.00% <100.00%> (ø)
packages/taiko-client/driver/preconf_blocks/api.go 0.00% <0.00%> (ø)
...kages/taiko-client/driver/preconf_blocks/server.go 19.46% <90.47%> (ø)
packages/taiko-client/pkg/rpc/client.go 44.91% <71.42%> (-4.03%) ⬇️
packages/taiko-client/driver/config.go 64.21% <62.50%> (-5.79%) ⬇️
packages/taiko-client/driver/driver.go 19.06% <0.00%> (-40.56%) ⬇️

... and 81 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c257ef...d921918. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cyberhorsey cyberhorsey enabled auto-merge April 25, 2025 21:16
@cyberhorsey cyberhorsey added this pull request to the merge queue Apr 26, 2025
Merged via the queue into main with commit abcc6a6 Apr 26, 2025
10 checks passed
@cyberhorsey cyberhorsey deleted the lookahead_sliding_window branch April 26, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants