chore(taiko-client): cleanup the Ontake fork decompression method (#19528)

Author: davidtaikocha

packages/taiko-client/driver/chain_syncer/event/blocks_inserter/pacaya.go

@@ -367,7 +367,7 @@ func (i *BlocksInserterPacaya) insertPreconfBlockFromExecutionPayload(
 	}
 
 	// Decompress the transactions list.
-	decompressedTxs, err := utils.DecompressPacaya(executableData.Transactions[0])
+	decompressedTxs, err := utils.Decompress(executableData.Transactions[0])
 	if err != nil {
 		return nil, fmt.Errorf("failed to decompress transactions list bytes: %w", err)
 	}

packages/taiko-client/driver/preconf_blocks/server.go

@@ -708,7 +708,7 @@ func (s *PreconfBlockAPIServer) ValidateExecutionPayload(payload *eth.ExecutionP
 	}
 
 	var txs types.Transactions
-	b, err := utils.DecompressPacaya(payload.Transactions[0])
+	b, err := utils.Decompress(payload.Transactions[0])
 	if err != nil {
 		return fmt.Errorf("invalid zlib bytes for transactions: %w", err)
 	}

packages/taiko-client/driver/txlist_decompressor/txlist_decompressor.go

@@ -60,7 +60,7 @@ func (v *TxListDecompressor) tryDecompress(
 	)
 
 	// Decompress the transaction list bytes.
-	if txListBytes, err = utils.DecompressPacaya(txListBytes); err != nil {
+	if txListBytes, err = utils.Decompress(txListBytes); err != nil {
 		log.Info("Failed to decompress tx list bytes", "error", err)
 		return types.Transactions{}
 	}

packages/taiko-client/pkg/utils/util_test.go

@@ -22,11 +22,6 @@ func TestEncodeDecodeBytes(t *testing.T) {
 	require.Nil(t, err)
 
 	require.Equal(t, b, decompressed)
-
-	decompressed, err = utils.DecompressPacaya(compressed)
-	require.Nil(t, err)
-
-	require.Equal(t, b, decompressed)
 }
 
 func TestGWeiToWei(t *testing.T) {

packages/taiko-client/pkg/utils/utils.go

@@ -104,32 +104,14 @@ func Compress(txList []byte) ([]byte, error) {
 	return b.Bytes(), nil
 }
 
-// Decompress decompresses the given txList bytes using zlib.
+// Decompress decompresses the given txList bytes using zlib, it checks the ErrUnexpectedEOF error.
 func Decompress(compressedTxList []byte) ([]byte, error) {
 	r, err := zlib.NewReader(bytes.NewBuffer(compressedTxList))
 	if err != nil {
 		return nil, err
 	}
 	defer r.Close()
 
-	b, err := io.ReadAll(r)
-	if err != nil {
-		if !errors.Is(err, io.EOF) && !errors.Is(err, io.ErrUnexpectedEOF) {
-			return nil, err
-		}
-	}
-
-	return b, nil
-}
-
-// DecompressPacaya decompresses the given txList bytes using zlib, it checks the ErrUnexpectedEOF error.
-func DecompressPacaya(compressedTxList []byte) ([]byte, error) {
-	r, err := zlib.NewReader(bytes.NewBuffer(compressedTxList))
-	if err != nil {
-		return nil, err
-	}
-	defer r.Close()
-
 	b, err := io.ReadAll(r)
 	if err != nil {
 		if !errors.Is(err, io.EOF) {